[Mono-dev] [PATCH] System.Configuration.Provider.ProviderBase.cs

Atsushi Eno atsushi at ximian.com
Fri Aug 31 02:48:20 EDT 2007


Hmm, I doubt. Your change looks strange (don't you think so? ;-)
Please provide verifiable test case that exactly shows the
behavioral difference.
I'd rather think there is something else to fix (if any).

Atsushi Eno

John Anderson wrote:
> When dealing with the configuration, after the ProviderBase finds the 
> Description it needs to remove it from the NameValueCollection, This is 
> how it happens in MS.NET <http://MS.NET>.
> 
> heres the patch:
> 
> Index: ProviderBase.cs
> ===================================================================
> --- ProviderBase.cs     (revision 85090)
> +++ ProviderBase.cs     (working copy)
> @@ -55,9 +55,15 @@
>                         _name = name;
>  
>                         if (config != null)
> -                               _description = config["description"];
> -                       if (_description == null)
> -                               _description = _name;
> +            {
> +                if (config["description"] != null)
> +                {
> +                    _description = config["description"];
> +                    config.Remove ("description");
> +                }
> +                else
> +                    _description = _name;
> +            }
>                 }
>  
>                 public virtual string Name {
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list




More information about the Mono-devel-list mailing list