[Mono-dev] Support for runtime configuration of assembly loading path - related to bug #81446

[Robert Jordan]

Hi Marek,

Marek Habersack wrote:
> On Thu, 23 Aug 2007 14:58:20 +0200, Paolo Molaro <lupus at ximian.com> scribbled:
> 
> Updated patch attached.
> 

A tiny issue:

> @@ -731,13 +860,13 @@
>  		 *
>  		 * The issue was reported in bug #81446
>  		 */
> -		slen = strlen (utf8);
> +		slen = strlen (search_path);
>  		for (i = 0; i < slen; i++)
> -			if (utf8 [i] == ':')
> -				utf8 [i] = ';';
> +			if (search_path [i] == ':')
> +				search_path [i] = ';';

I'd surround the ":" -> ";" substitution by a #ifndef PLATFORM_WIN32
block, because privatePath may contain absolute paths[1] and ":" is
the drive separator on this platform.

Robert

[1]

This works on MS.NET, as long "c:\tmp\foo" is pointing to a subdirectory
of the application's directory:

<configuration>
    <runtime>
       <assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
          <probing privatePath="c:\tmp\foo"/>
       </assemblyBinding>
    </runtime>
</configuration>