[Mono-dev] [PATCH] System.Xml.Serialization: do not export same simple type several times

[Atsushi Eno]

It's not only about breakage detection. If someone broke your fix and
there was
no corresponding test, and then you report the person about that, he or
she will
never fix the issue since there is no way to reproduce the issue at his
or her side.

Atsushi Eno

Konstantin Triger wrote:
> Yes, I understand that having a public test case is much better.
> We have an internal WebServices test suite (which we cannot submit to mono), that ensures the relevant scenario is working. If someone will break the flow, we will know about it.
>
> Thanks,
> Kosta
>
>   
>> -----Original Message-----
>> From: Atsushi Eno [mailto:atsushi at ximian.com]
>> Sent: Thursday, April 19, 2007 7:51 PM
>> To: Konstantin Triger
>> Cc: Mono Development List
>> Subject: Re: [Mono-dev] [PATCH] System.Xml.Serialization: do not export
>> same simple type several times
>>
>> As long as there is no test no one will assure its stability
>> but if you still want you can go ahead and commit the patch.
>>
>> Atsushi Eno
>>
>> Konstantin Triger wrote:
>>     
>>> Hi,
>>>
>>> Any WebService with char in a signature.
>>>
>>> Regards,
>>> Konstantin Triger
>>>
>>>       
>>>> -----Original Message-----
>>>> From: mono-devel-list-bounces at lists.ximian.com [mailto:mono-devel-list-
>>>> bounces at lists.ximian.com] On Behalf Of Atsushi Eno
>>>> Sent: Thursday, April 19, 2007 5:42 PM
>>>> To: Mono Development List
>>>> Subject: Re: [Mono-dev] [PATCH] System.Xml.Serialization: do not export
>>>> same simple type several times
>>>>
>>>> Hi,
>>>>
>>>> Thanks for the patch, but do you have the actual test case?
>>>>
>>>> Atsushi Eno
>>>>
>>>> Konstantin Triger wrote:
>>>>         
>>>>> Hello,
>>>>>
>>>>> The attached patch ensures the simple types are exported only once. So
>>>>>           
>>>> VS correctly generates webservice proxy for types "derived" from xsd
>>>> primitives, like char.
>>>>         
>>>>> Please review.
>>>>>
>>>>> Regards,
>>>>> Konstantin Triger
>>>>>
>>>>>
>>>>>
>>>>> ----------------------------------------------------------------------
>>>>>           
>> --
>>     
>>>>> _______________________________________________
>>>>> Mono-devel-list mailing list
>>>>> Mono-devel-list at lists.ximian.com
>>>>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>>>>           
>>>> _______________________________________________
>>>> Mono-devel-list mailing list
>>>> Mono-devel-list at lists.ximian.com
>>>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>>>         
>
>
>