[Mono-dev] [PATCH] - System.IO.FileSystemWatcher Unit Tests for Events

[Miguel de Icaza]

Hello,

> One thing you should do is make sure your temp files and directories
> are cleaned up when your tests finish running. The best way to do this
> would be to use [TestFixtureSetup] and [TestFixtureTeardown] to create
> a setup and cleanup method. The first one creates your temp directory,
> the second one deletes it. 
> 
> Other than that, it looks good.

Although if the tests are failing on MacOS X, we should not run them on
OSX.

Miguel.

> Alan.
> 
> 
> 
> On 4/18/07, Louis R. Marascio <louis at fitnr.com> wrote:
>         Louis R. Marascio <louis at fitnr.com> wrote: 
>         >Attached is a patch that adds several unit tests for
>         FileSystemWatcher.
>         >These tests focus on verifying that the Created, Deleted, and
>         Changed
>         >events work properly. This work was driven from my trying to
>         track down 
>         >bug #80564 wherein the Changed events don't fire properly on
>         OS X.
>         >
>         >I tested this patch on gentoo with the a mono build from svn,
>         revision
>         >75497. All new tests pass on Linux. As expected, one test is
>         failing on 
>         >OS X due to bug #80564. I did not run the new tests on
>         Windows.
>         >
>         >This is my first patch so please let me know if I've done
>         anything
>         >wrong.
>         
>         Bump. Can someone review this?
>         
>         Thanks, 
>         
>         Louis
>         _______________________________________________
>         Mono-devel-list mailing list
>         Mono-devel-list at lists.ximian.com
>         http://lists.ximian.com/mailman/listinfo/mono-devel-list
> 
> 
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list