[Mono-dev] Patch to install gnome-keyring-sharp into the GAC

[Alp Toker]

Miguel de Icaza wrote:
> Hello,
> 
>> Attached are the files needed to patch gnome-keyring-sharp so it will
>> install itself into the GAC when doing a make install.  Copy the
>> Gnome.Keyring.key file to the root of the project, apply the patch,
>> and you'll be good to go.
> 
> Gonzalo is the developer for Gnome Keyring # and he has left Novell.
> 
> The only issue with installing stuff into the GAC is that once we commit
> to install things into the GAC, we have to preserve its API, we can not
> remove/change any APIs that are there.
> 
> I do not mind adding the patch, but I would like for someone to step up
> and take over maintenance.
> 
> Miguel.

I've made the last few commits to this module, and am pretty familiar 
with it by now. Gonzalo wrote some lovely code.

I think I might be able to maintain it, but there are some things I'd 
want to do before committing to a long-term ABI guarantee for the GAC:

  * Consider using SecureString for authentication tokens. Even if this 
class isn't yet "secure" in Mono (I have an implementation in the works, 
need to check with Seb), I wouldn't be comfortable being responsible for 
a library that knowingly stores critical data cleartext in the heap.

  * Make sure all implementation details are internal.

  * Check with the C gnome keyring implementation to see if there have 
been additions/deprecations since Gnome.Keyring was written.

  * Try to get a public API review from the C gnome keyring authors.