[Mono-dev] Microsoft.Build.* API fixes

[Leszek Ciesielski]

On 10/20/06, Marek Sieradzki <marek.sieradzki at gmail.com> wrote:
> On 10/20/06, Leszek Ciesielski <skolima at gmail.com> wrote:
> > Hi,
> >
> > attached is a patch fixing minor attribute differences between mono
> > and ms.net, and containing stubs for (some of) missing classes.
> > Permission to commit?
> >
> Hi,
>
> AssemblyInfo.cs changes are questionable. If there's a good reason for
> them please specify it.

Those attributes are present in MS.Net assembly ( consult eg. mono
class status). Other that that - none, I dubt mono supports them at
this time (meaning "pays any heed to them", I know compiler generates
them properly). It's just a small increase in compatibility, when I
could see no problems on our side. I do not want to argue, but if you
are against applying them, please specify a reason :-)

>
> Small coding style glitch. You are using "F()" instead of "F ()"

And you are using tabs instead of spaces (check the coding guidelines
:P). I forgot about that, will fix it.

>
> VCBuild is a class that rather won't be implemented. In MSBuild it
> executes VS C++ build (that uses different format of project files).
> It is possible that someone can use gcc/g++ for that but generally I'm
> not sure if anyone will use it. Anyway monotodo +
> notimplementedexception stub can be added.
>
> Vbc task should be quite easy to write when we'll have it working on Mono.