[Mono-dev] [PATCH] XPathNavigator.CanEdit

[Konstantin Triger]

Hi Eno,

You are absolutely right - that's my miss, thanks.

Regards,
Konstantin Triger

-----Original Message-----
From: Atsushi Eno [mailto:atsushi at ximian.com] 
Sent: Tuesday, October 10, 2006 4:59 PM
To: Konstantin Triger
Cc: mono-devel-list at lists.ximian.com
Subject: Re: [Mono-dev] [PATCH] XPathNavigator.CanEdit

Hello Kosta,

Thanks for the patch. CanEdit needed a fix for sure. Though the patch
was kind of wrong and I fixed it a bit differently.
XmlDocumentNavigator itself is designed to be read-only (it does not
implement any of editing methods) and thus it should not return CanEdit
as true, so that someone who derives another XPathNavigator based on it
would not be messed by CanEdit result. Only XmlDocumentEditableNavigator
should override it.

Atsushi Eno

Konstantin Triger wrote:
> Hello,
> 
>  
> 
> The attached patch and a test case set the CanEdit property according to msdn.
> 
>  
> 
> Please review.
> 
>  
> 
> Regards,
> 
> Konstantin Triger
> 
>  
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list