[Mono-dev] System.dll few patches for review

[Raja R Harinath]

Hi,

"Andrew Skiba" <andrews at mainsoft.com> writes:

> Please review these patches for System.dll.
>
> Part of them is needed to omit TARGET_JVM, so code will be common.
>
> * DigestClient.patch - use MD5.Create instead of HashAlgorithm.Create
> ("MD5")
>
> * X509CertificateCollection.patch - remove unnecessary overload
>
> Thank you.
> Andrew.
>
> Index: System.Net/DigestClient.cs
> ===================================================================
> --- System.Net/DigestClient.cs	(revision 66034)
> +++ System.Net/DigestClient.cs	(working copy)
> @@ -248,9 +248,9 @@
>  				return false;
>  			}
>  
> -			// build the hash object (only MD5 is defined in RFC2617)
> -			if ((parser.Algorithm == null) || (parser.Algorithm.ToUpper ().StartsWith ("MD5")))
> -				hash = HashAlgorithm.Create ("MD5");
> +			// build the hash object (only MD5 is defined in RFC2617)
> +			if ((parser.Algorithm == null) || (parser.Algorithm.ToUpper ().StartsWith ("MD5")))
> +				hash = MD5.Create ();
>  
>  			return true;
>  		}

Hmm, there's a stealth CR-LF in the patch.  Can you fix that.  Even
better, set the svn:eol-style property of that file to native to prevent
such issues.

- Hari