[Mono-dev] [Mono-patches] r68496 - in trunk/mcs/class/System.Web:System.Web.UI Test/System.Web.UI

[Igor Zelmanovich]

Gonzalo,

OpenFile may be implemented this way:

protected internal Stream OpenFile (string path)
{
	return System.Web.Hosting.VirtualPathProvider.OpenFile (path);
}

In this case the corresponding test fails because
DefaultVirtualPathProvider.GetFile not supports application relative
path (such as "~/MyPage.aspx").

I attached corresponding tests.
Please, review.

Igor.

-----Original Message-----
From: Gonzalo Paniagua Javier [mailto:gonzalo at novell.com] 
Sent: Monday, November 27, 2006 8:55 PM
To: Igor Zelmanovich; Mono Development
Subject: Re: [Mono-patches] r68496 - in
trunk/mcs/class/System.Web:System.Web.UI Test/System.Web.UI

On Mon, 2006-11-27 at 04:28 -0500, Igor Zalmanovich (igorz at mainsoft.com)
wrote:
> Author: igorz
> Date: 2006-11-27 04:28:15 -0500 (Mon, 27 Nov 2006)
> New Revision: 68496
> 
> Modified:
>    trunk/mcs/class/System.Web/System.Web.UI/ChangeLog
>    trunk/mcs/class/System.Web/System.Web.UI/Control.cs
>    trunk/mcs/class/System.Web/Test/System.Web.UI/ChangeLog
>    trunk/mcs/class/System.Web/Test/System.Web.UI/ControlTest.cs
> Log:
> 2006-11-27 Igor Zelmanovich <igorz at mainsoft.com>
> 
> 	* Control.cs: implemented OpenFile()
> 

The correct implementation of OpenFile have to use the current
VirtualPathProvider. The patch you commited works for the general case,
but if someone provides a special VirtualPathProvider, it won't work.
Please, fix it.

-Gonzalo



-------------- next part --------------
A non-text attachment was scrubbed...
Name: HostingEnvironmentTest.patch
Type: application/octet-stream
Size: 1792 bytes
Desc: HostingEnvironmentTest.patch
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20061128/e93c1534/attachment.obj