[Mono-dev] [PATCH] Implementations of several properties in ASP.NET 2.0 Control class

[Chris Toshok]

On Mon, 2006-11-20 at 13:05 +0100, Marek Habersack wrote:
> On Mon, 20 Nov 2006 17:25:25 +0530, Raja R Harinath
> <rharinath at novell.com> scribbled:
> 
> Hey Raja,
> 
> [snip]
> > >  				string client = UniqueID;
> > >  
> > >  				if (client != null)
> > > -					client = client.Replace
> > > (':', '_'); -
> > > +					client = client.Replace
> > > (':', +#if NET_2_0
> > > +
> > > ClientIDSeparator +#else
> > > +
> > > '_'); +#endif
> > >  				return client;
> > >  			}
> > 
> > Yow, that's ugly :-)  I'd prefer that you use ClientIDSeparator
> It is ugly, indeed :)
> 
> > unconditionally, and ...
> >   		}
> > > @@ -202,7 +206,7 @@
> > >  		protected char ClientIDSeparator 
> > >  		{
> > >  			get {
> > > -				throw new NotImplementedException
> > > ();
> > > +				return '_';
> > >  			}
> > >  		}
> > >  #endif
> > 
> > Pull this outside the NET_2_0 ifdef, and make it 'private' (or at
> > worst, 'protected internal') #if !NET_2_0 instead.
> Done - please see the attached diff,

"protected internal" modifies the public api, and isn't allowed.  It
should be private in the !NET_2_0 case.

Chris