[Mono-dev] [PATCH] Implementations of several properties in ASP.NET 2.0 Control class

[Marek Habersack]

On Mon, 20 Nov 2006 17:25:25 +0530, Raja R Harinath
<rharinath at novell.com> scribbled:

Hey Raja,

[snip]
> >  				string client = UniqueID;
> >  
> >  				if (client != null)
> > -					client = client.Replace
> > (':', '_'); -
> > +					client = client.Replace
> > (':', +#if NET_2_0
> > +
> > ClientIDSeparator +#else
> > +
> > '_'); +#endif
> >  				return client;
> >  			}
> 
> Yow, that's ugly :-)  I'd prefer that you use ClientIDSeparator
It is ugly, indeed :)

> unconditionally, and ...
>   		}
> > @@ -202,7 +206,7 @@
> >  		protected char ClientIDSeparator 
> >  		{
> >  			get {
> > -				throw new NotImplementedException
> > ();
> > +				return '_';
> >  			}
> >  		}
> >  #endif
> 
> Pull this outside the NET_2_0 ifdef, and make it 'private' (or at
> worst, 'protected internal') #if !NET_2_0 instead.
Done - please see the attached diff,

best regards,

marek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Control.cs.diff
Type: text/x-patch
Size: 1073 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20061120/6ff27940/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20061120/6ff27940/attachment-0001.bin