[Mono-dev] [PATCH] Proxy detection under 2.0 (+ config bug?)

[Michael Hutchinson]

On 11/1/06, Gonzalo Paniagua Javier <gonzalo at novell.com> wrote:
> Please, commit.

Actually, I've made a few tweaks...

I got onto Win32 and checked how the config code behaves. Both
ConfigurationSettings.GetConfig and ConfigurationManager.GetSection
should respect machine.config, but they don't on Mono 2.0. Given this,
the latter is clearly the right choice for this patch to use, though
it won't use machine.config settings till this is fixed. I'll follow
it up on bugzilla.

*However*, according to
http://msdn2.microsoft.com/en-gb/library/kd3cf2ex.aspx, "If the
defaultProxy element is empty, the proxy settings from Internet
Explorer will be used. This behavior is different from version 1.1 of
the .NET Framework.". Checking the default .NET 2.0 machine.config it
doesn't even have a <system.net> section, so I've changed the default
behaviour in this case to use system settings, and removed the
<defaultProxy> section from the config file. This means that not using
machine.config just yet won't matter for most users.

Should I commit?

-- 
Michael Hutchinson
http://mjhutchinson.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: config.diff
Type: text/x-patch
Size: 1381 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20061102/eb63a5ff/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: proxydefaults.diff
Type: text/x-patch
Size: 1527 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20061102/eb63a5ff/attachment-0001.bin