[Mono-dev] [PATCH] System.Data API signature fixes

[Gert Driesen]

Hi,

The attached patch fixes some API signature fixes for System.Data:

* SqlConnection.cs: Removed extra destructor, as destructor on
System.ComponentModel.Component already calls Dispose.
* SqlParameter.cs: Removed explicit interface implementation of
IDataParameter.ParameterName.
* OdbcErrorCollection.cs: Removed explicit interface implementation
of IEnumerable.GetEnumerator ().
* OdbcCommand.cs: Removed destructor as the destructor in
System.ComponentModel.Component already calls the Dispose method.
Removed explicit interface implemenation of members that are
implement by public members.
* OdbcDataReader.cs: Removed explicit interface implemenation of
IDataRecord.GetData.
* OleDbErrorCollection.cs: Removed explicit interface implementation
of IEnumerable.GetEnumerator ().
* OleDbParameterCollection.cs: Removed explicit interface
implementation members that are already implementation by public
members.
* DataTable.cs: Renamed initInProgress to fInitInProgress. BeginInit
and EndInit must only be virtual in 2.0 profile. Set eol-style to CRLF.

I noticed that Mono's System.Data also introduces a namespace (namely
System.Data.ProviderBase) that does not exist in .NET (1.x or 2.0).

There are quite some API signature mismatches because Mono classes
derive from base classes in that namespace. Do you want me to post a
patch for this too ?

Is it ok to commit the attached patch as is ?

Gert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sd.patch
Type: text/x-patch
Size: 10798 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20060531/d3e5b8a4/attachment.bin