[Mono-dev] Patch for HttpRequest.cs

[Juraj Skripsky]

Hi,

These are the separate and slightly refactored patches for
HttpUtility.cs, HttpRequest.cs and HttpRequestTest.cs:

2006-05-28 Juraj Skripsky <js at hotfeet.ch>

	* HttpUtility.cs (ParseQueryString): move core of
	ParseQueryString into internal method to make it available to 
	HttpRequest. Use Encoding.Default if no encoding is given as 
	that's what MS does.

2006-05-28 Juraj Skripsky <js at hotfeet.ch>

	* HttpRequest.cs: simplify code around uri_builder (and rename 
	to url_components). Move storage of query_string into 
	uri_builder.Query and initialize it lazily using 
	worker_request.GetQueryStringRawBytes() or GetQueryString().
	(QueryString): Use HttpUtility.ParseQueryString instead of 
	duplicating its functionality.


2006-05-28 Juraj Skripsky <js at hotfeet.ch>

        * HttpRequestTest.cs: add test case to verify that the correct 
	encoding is used during url-decoding of the query string.


All NUnit tests pass, xsp and mod_mono seem to be happy as well.
May I commit?

- Juraj


On Fri, 2006-05-26 at 09:55 -0400, Gonzalo Paniagua Javier wrote: 
> On Fri, 2006-05-26 at 15:26 +0200, Juraj Skripsky wrote:
> > I will do some more testing with a few websites of our own. If
> > everything works fine, I would like to commit the changes.
> 
> I would prefer to get separated patches with a ChangeLog. Also the
> changes that involve UriBuilder might break PathInfo. Make sure you test
> those with apache/mod_mono and xsp.
> 
> Thanks.
> 
> -Gonzalo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: HttpUtility.patch
Type: text/x-patch
Size: 1874 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20060528/dc04912a/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: HttpRequest.patch
Type: text/x-patch
Size: 5802 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20060528/dc04912a/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: HttpRequestTest.patch
Type: text/x-patch
Size: 691 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20060528/dc04912a/attachment-0002.bin