[Mono-dev] [PATCH RESEND] - 2 patches for system.web

[Andrew Skiba]

Sorry, I made a mistake, when I sent you diagnostic output. I used
non-patched sys.web from a wrong dir, and it produced no output. The
discussed patch is correct, however :-)

Also, the testcase was not representative enough. Please use same tests
and diag-patch from this message. Also for your convenience, I updated
the ApplyTheme.patch. If you have rejects of the patch I sent before 3
weeks, because few context lines was changed, you can use the fresh one.

What's missing in unpatched flow is the ApplyTheme (that changes
ImageURL), which must happen right before child.OnInit. My patch does
exactly that.

dot net outputs
child.ApplyStyleSheetSkin
before parent.AddedControl
after parent.AddedControl
child.set_ImageURL
child.OnInit
before parent.OnInit
after parent.OnInit
before parent.CreateChildControls
after parent.CreateChildControls

before patch
child.ApplyStyleSheetSkin
before parent.AddedControl
after parent.AddedControl
child.OnInit
before parent.OnInit
after parent.OnInit
before parent.CreateChildControls
after parent.CreateChildControls

after patch
child.ApplyStyleSheetSkin
before parent.AddedControl
after parent.AddedControl
child.set_ImageURL
child.OnInit
before parent.OnInit
after parent.OnInit
before parent.CreateChildControls
after parent.CreateChildControls


> -----Original Message-----
> From: mono-devel-list-bounces at lists.ximian.com 
> [mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf 
> Of Andrew Skiba
> Sent: Thursday, May 11, 2006 17:37
> To: Chris Toshok
> Cc: mono-devel-list at lists.ximian.com
> Subject: RE: [Mono-dev] [PATCH RESEND] - 2 patches for system.web
> 
> Hi Chris.
> 
> You wrote:
> > as for ApplyTheme.patch, I'm still waiting for a test for 
> that as well 
> > (not a behavioral one, one that actually points out where in the 
> > lifecycle the theme stuff happens.)
> 
> Please look at attached websites for dotnet and mono. On 
> dotnet I subclassed Panel and ImageButton to see lifecycle of 
> parent and child webcontrols. The output was:
> 
> child.ApplyStyleSheetSkin
> child.set_ImageURL
> before parent.AddedControl
> after parent.AddedControl
> child.set_ImageURL
> child.OnInit
> before parent.OnInit
> after parent.OnInit
> before parent.CreateChildControls
> after parent.CreateChildControls
> 
> On mono I changed sys.web code (attached patch - not for 
> committing) to see tracing. Before patch I've got:
> ***NOTHING!!!*** No output because no controls were created 
> whatsoever.
> 
> After patch I've got:
> child.ApplyStyleSheetSkin
> child.set_ImageURL
> before parent.AddedControl
> after parent.AddedControl
> child.set_ImageURL
> before parent.OnInit
> after parent.OnInit
> before parent.CreateChildControls
> after parent.CreateChildControls
> 
> Regards,
> Andrew.
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PageLinks.mono.zip
Type: application/x-zip-compressed
Size: 12410 bytes
Desc: PageLinks.mono.zip
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20060511/74bbe82e/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PageLinks.dotnet.zip
Type: application/x-zip-compressed
Size: 13431 bytes
Desc: PageLinks.dotnet.zip
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20060511/74bbe82e/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diag.patch
Type: application/octet-stream
Size: 2125 bytes
Desc: diag.patch
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20060511/74bbe82e/attachment.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ApplyTheme.patch
Type: application/octet-stream
Size: 2026 bytes
Desc: ApplyTheme.patch
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20060511/74bbe82e/attachment-0001.obj