[Mono-dev] [PATCH RESEND] - 2 patches for system.web

Chris Toshok toshok at ximian.com
Wed May 10 16:29:45 EDT 2006

Forget about making a test, I made one of my own, in
Test/standalone/themes/TestTheme4.  Keep in mind when I say "test", i
don't necessarily mean "unit test".

Anyway, the test is pretty simple, it just overrides OnInit and doesn't
chain up to the parent's method.  It shows that your code is correct,
and as such the PageTheme.patch can go in.

Please don't submit patches anymore without corresponding tests.
Especially when altering/adding life cycle code, as 1 behavioral test
(PageLinks) is not enough to prove that your patch is correct.


On Wed, 2006-05-10 at 07:36 -0700, Andrew Skiba wrote:
> PageLinks.zip:
> Cutted-down version of Personal Web Site starter kit from Microsoft,
> which was used to reveal the problems in the flow.
> ApplyTheme.patch:
> In current mono implementation theme is applied for all the control
> hierarchy before applying the master page. But at this stage many
> controls still don't exist. This patch solves problem with master page,
> and with contols created during PreRerderRecursiveInternal. This patch
> solves the problem and removes code duplication for recursion.
> PageTheme.patch:
> This patch uses LinkedStyleSheets from the PageTheme and from
> StyleSheetPageTheme to insert links in page header.
> If no one objects, I will commit.
> Andrew.
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list

More information about the Mono-devel-list mailing list