[Mono-dev] Bug in System.WebHttpUtility.UrlDecode

[Vladimir Krasnov]

Hi Gonzalo,

You've merged my patch that contained fixes for 3 overloads of DecodeUrl
but in the first one (UrlDecode (string, Encoding)) you've merged not
exactly what I meant. You've used TryParseHexa function that throws
exception if failed to parse hex number, this is what I wanted to avoid,
because this can a little slow down a performance of URL decoding. The
next two overloads are not using this function.

Did you have a special reason for this?

-----Original Message-----
From: mono-devel-list-bounces at lists.ximian.com
[mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf Of Gonzalo
Paniagua Javier
Sent: Tuesday, April 11, 2006 1:13 AM
To: mono-devel-list at lists.ximian.com
Subject: Re: [Mono-dev] Bug in System.WebHttpUtility.UrlDecode

On Mon, 2006-03-27 at 01:56 -0800, Vladimir Krasnov wrote:
> Hello,
> 
> There is a bug in UrlDecode method in System.WebHttpUtility, when two
> precent chars '%%' are present in encoded Url, UrlDecode fails to
> decode. Also, when the % char follows characters that are not hex
> numbers, the result of UrlDecode is wrong.
> 
> Look at attached test cases and the patch that fixes this bug.
> If no one objects I will commit

Hi Vladimir.

I just merged in the stuff from your patch that wasn't fixed yet after
the changes in the last 2 weeks.

Thanks.

-Gonzalo


_______________________________________________
Mono-devel-list mailing list
Mono-devel-list at lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list