[Mono-dev] Re: Please Help : Leak of wapi handles

[Miguel de Icaza]

Hello,

> You probably mean this fix:
> 
> http://lists.ximian.com/pipermail/mono-patches/2006-May/074236.html
> 
> It doesn't fix the thread handles ref leaks I experienced.
> 
> I was able to fix it by changing io-layer/threads.cs:GetCurrentThread
> to not ref the handle. I'm not sure about the side effects, still
> testing.

Ah, I felt that would help.

Taking the ref inside GetCurrentThread in my opinion is an incorrect
change.   But I do not understand the ChangeLog entry nor why was that
patch supposed to fix the other bug (or if the other bug listed on the
SVN commit message is even the same fix).

Gonzalo sent an email to Dick on Friday, we are waiting to see.

Miguel