[Mono-dev] Creating fewer objects (Sys.Xml, Sys.Web)

Atsushi Eno atsushi at ximian.com
Mon Mar 27 20:18:51 EST 2006


Joshua Tauberer wrote:
> (My patch was cooler!)

Well, I have to say, it was beyond my expectation for me ;-)
On which part was your patch cooler? I don't think
specific-implementation-dependent code (internal AddQName) is good,
and more importantly, after your code future hackers would feel
reluctant to improve NameTable since your patch adds extra one
to care.

> (And: I don't know if it was necessary, but XmlElement was checking if
> prefix == null which you're not checking for in your patch.)

Oh, it should check that too, for namespace-less XmlTextReader input.

Atsushi Eno

More information about the Mono-devel-list mailing list