[Mono-dev] Re: [Mono-patches] r57679 - in trunk/mcs/class/corlib: System System.Globalization

[Zac Bowling]

I love the "BIG FAT WARNING".

Maybe should of used an ascii art bomb like this one to REALLY get the 
point across.

      ,--.!,
   __/   -*-
,d08b.  '|`
0088MM     `9MMP'



-- 
Zac Bowling
http://zacbowling.com/


----- Message from mono-patches-list at lists.ximian.com ---------
    Date: Tue,  7 Mar 2006 18:30:00 -0500 (EST)
    From: "Peter Bartok (peter at novonyx.com)" 
<mono-patches-list at lists.ximian.com>
Reply-To: "Peter Bartok (peter at novonyx.com)" 
<mono-patches-list at lists.ximian.com>
Subject: [Mono-patches] r57679 - in trunk/mcs/class/corlib: System 
System.Globalization
      To: mono-patches at lists.ximian.com, ximian.monolist at gmail.com, 
mono-patches-list at googlegroups.com


> Author: pbartok
> Date: 2006-03-07 18:29:59 -0500 (Tue, 07 Mar 2006)
> New Revision: 57679
>
> Modified:
>   trunk/mcs/class/corlib/System.Globalization/ChangeLog
>   trunk/mcs/class/corlib/System.Globalization/DateTimeFormatInfo.cs
>   trunk/mcs/class/corlib/System/ChangeLog
>   trunk/mcs/class/corlib/System/Environment.cs
> Log:
> 2006-03-07  Peter Dennis Bartok  <pbartok at novell.com>
>
> 	* Environment.cs: Bumped corlib version to 48 (due to r57532)
>
> 2006-03-07  Peter Dennis Bartok  <pbartok at novell.com>
>
> 	* DateTimeFormatInfo.cs: Restored original field order to allow
> 	  some automatic locale fu to happen (mono unmanaged code relies
> 	  on the field order to fill out DateTimeFormatInfo)
>
>
>
> Modified: trunk/mcs/class/corlib/System/ChangeLog
> ===================================================================
> --- trunk/mcs/class/corlib/System/ChangeLog	2006-03-07 23:29:14 UTC 
> (rev 57678)
> +++ trunk/mcs/class/corlib/System/ChangeLog	2006-03-07 23:29:59 UTC 
> (rev 57679)
> @@ -1,3 +1,7 @@
> +2006-03-07  Peter Dennis Bartok  <pbartok at novell.com>
> +
> +	* Environment.cs: Bumped corlib version to 48 (due to r57532)
> +
> 2006-03-07  Martin Baulig  <martin at ximian.com>
>
> 	* String.cs (String.FormatHelper): Try getting an `ICustomFormatter'
>
> Modified: trunk/mcs/class/corlib/System/Environment.cs
> ===================================================================
> --- trunk/mcs/class/corlib/System/Environment.cs	2006-03-07 23:29:14 
> UTC (rev 57678)
> +++ trunk/mcs/class/corlib/System/Environment.cs	2006-03-07 23:29:59 
> UTC (rev 57679)
> @@ -59,7 +59,7 @@
> 		 * Changes which are already detected at runtime, like the addition
> 		 * of icalls, do not require an increment.
> 		 */
> -		private const int mono_corlib_version = 47;
> +		private const int mono_corlib_version = 48;
>
> 		[MonoTODO]
> 		public enum SpecialFolder
>
> Modified: trunk/mcs/class/corlib/System.Globalization/ChangeLog
> ===================================================================
> --- trunk/mcs/class/corlib/System.Globalization/ChangeLog	2006-03-07 
> 23:29:14 UTC (rev 57678)
> +++ trunk/mcs/class/corlib/System.Globalization/ChangeLog	2006-03-07 
> 23:29:59 UTC (rev 57679)
> @@ -1,3 +1,9 @@
> +2006-03-07  Peter Dennis Bartok  <pbartok at novell.com>
> +
> +	* DateTimeFormatInfo.cs: Restored original field order to allow
> +	  some automatic locale fu to happen (mono unmanaged code relies
> +	  on the field order to fill out DateTimeFormatInfo)
> +
> 2006-03-02  Peter Dennis Bartok  <pbartok at novell.com>
>
> 	* DateTimeFormatInfo.cs: Switched (where possible) our internal
>
> Modified: trunk/mcs/class/corlib/System.Globalization/DateTimeFormatInfo.cs
> ===================================================================
> --- 
> trunk/mcs/class/corlib/System.Globalization/DateTimeFormatInfo.cs	2006-03-07 
> 23:29:14 UTC (rev 57678)
> +++ 
> trunk/mcs/class/corlib/System.Globalization/DateTimeFormatInfo.cs	2006-03-07 
> 23:29:59 UTC (rev 57679)
> @@ -53,6 +53,14 @@
>
> 		private static DateTimeFormatInfo theInvariantDateTimeFormatInfo;
>
> +		//
> +		// BIG FAT WARNING:
> +		//
> +		// DO NOT ALTER THE NAME OR ORDER OF THESE FIELDS
> +		// AND DO NOT INSERT ANY VARIABLES ANYWHERE BUT AT THE END
> +		// SINCE MONO RELIES ON THE ORDER AND ON THE NAMES
> +		// see mono/mono/metadata/verify.c
> +		//
> 		private bool m_isReadOnly;
> 		private string amDesignator;
> 		private string pmDesignator;
> @@ -76,6 +84,18 @@
> 		private string[] monthNames;
> 		private string[] abbreviatedMonthNames;
>
> +		// FIXME: not supported other than invariant
> +		private string [] allShortDatePatterns;
> +		private string [] allLongDatePatterns;
> +		private string [] allShortTimePatterns;
> +		private string [] allLongTimePatterns;
> +		private string [] monthDayPatterns;
> +		private string [] yearMonthPatterns;
> +
> +		//
> +		// END OF BIG FAT WARNING
> +		//
> +
> 		// MS Serialization needs this
> 		private int nDataItem;
> 		private bool m_useUserOverride;
> @@ -90,14 +110,6 @@
> 		private string[] m_dateWords;
> 		private int[] optionalCalendars;
>
> -		// FIXME: not supported other than invariant
> -		private string [] allShortDatePatterns;
> -		private string [] allLongDatePatterns;
> -		private string [] allShortTimePatterns;
> -		private string [] allLongTimePatterns;
> -		private string [] monthDayPatterns;
> -		private string [] yearMonthPatterns;
> -
> 		public DateTimeFormatInfo()
> 		{
> 			m_isReadOnly = false;
>
> _______________________________________________
> Mono-patches maillist  -  Mono-patches at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-patches
>
>


----- End message from mono-patches-list at lists.ximian.com -----