[Mono-dev] RE: [Mono-patches] r57149 - in trunk/mcs/class/System.Data: System.DataSystem.Data.Common Test/ProviderTests/System.Data.SqlClientTest/System.Data

Atsushi Eno atsushi at ximian.com
Mon Mar 6 03:55:56 EST 2006

It sounds reasonable only if everyone is ready to "sign"
certificates for each of non-trivial patches so that he or she
has assured that each does not break anything.

I don't think such "review" work well. It should be fine if someone
who broke tests fix the problem, or just revert in case it was
impossible. That's what has happened to such patches that are
accompanied by "please review the patch" posts.

The same amount of "massive" patches happen to mcs/gmcs land
without any approvals from the maintainers, kinda everyday.

Atsushi Eno

Boris Kirzner wrote:
> Hello Senga,
> One of your latest updates introduces a regression (see attached test
> case, passes on r57148 but fails on r57149), due to the change in Key
> default row state filter.
> Please, next time you want to introduce some changes that has such a
> wide effect, especially in the code you do not wrote by your own, maybe
> it worth to give this fixes an opportunity to be reviewed by the
> community before applying them.
> Thanks,
> Boris

More information about the Mono-devel-list mailing list