[Mono-dev] Patch file for System.Net.Sockets NetworkStream class for NET 2.0

[Ympostor]

Sridhar Kulkarni wrote:
> Attached is a patch file for System.Net.Sockets, NetworkStream class for 
> NET 2.0.

Hello. Just wondering... (never reviewed a patch):

> +        public override bool CanTimeout {
> +            get {
> +                return (true);
> +            }

Are the parenthesis required by the Mono coding style guidelines in 
return statements?


> +
> +        public override int ReadTimeout {
> +            get {
> +                return (ReadTimeout);
> +            }

Wouldn't this create an infinite loop? (I suppose you have to put 
"readTimeout".

> ...
> +            else{
> +                System.Timers.Timer closTimer = new System.Timers.Timer();
> ...

If you have used a "using System.Timers", why don't you take advantage 
of it here?


Regards

--