[Mono-dev] System.Data changes for System.Windows.Forms databinding/datagrid

[Chris Toshok]

On Wed, 2006-06-21 at 04:15 -0600, T Senganal wrote:
> Hi 
> 
> > Subject says it all.
> 
> The patch breaks existing tests in System.Data..
> 
> > +	Also, make a couple of small changes so that the events are
> fired
> > +	in the same sequence as MS.
> 
> yes, the events are not raised correctly in some cases (there is a
> notworking test for this), 
> but the patch breaks current tests.. will look into it..
> 
> >+	* DataRow.cs: Don't call EndEdit after setting the value of a
> >+	column.  The old code caused new rows to be committed by the
> >+	DataGrid when the user moved the cursor between columns, which
> >+	isn't MS behavior.
> 
> i dont see a problem with the way DataRow is being currently handled.. 
> if EndEdit is not called, RowState  is not set correctly and lot of
> operations 
> depend on RowState.. probably this needs to be fixed in the DataGrid.. 

Hm, okay.  I'll dig more into this.

> The other changes seem fine..

Okay, I'll commit the DataViewManager and DataView.GetItemProperties
changes.

Chris