[Mono-dev] [PATCH] System.Web.Compilation.TemplateControlCompiler

[Gonzalo Paniagua Javier]

On Wed, 2006-06-14 at 06:37 -0700, Andrew Skiba wrote:
> Hello,
> 
> Please review test and patch for TemplateControlCompiler. The bug was
> that assignment statement was generated for a read-only property. If no
> one objects, I will commit.

I don't think this patch is ok. And I'm tired of seeing that 'if no one
objects, I'll commit'. You should wait patiently until the patch is
approved and resubmit if you get no answer, which is what everyone else
does.

AddCodeForPropertyOrField can be called with a FieldInfo, and this will
make:
+                       if (isDataBound && ((PropertyInfo)
member).CanWrite) {

crash.

-Gonzalo