[Mono-dev] [PATCH] Speed up ByteEncoding.GetString()

Atsushi Eno atsushi at ximian.com
Wed Jun 14 13:15:59 EDT 2006

Kornél Pál wrote:
>> I am confused: which is your true opinion?
>> 1)
>> > OK, now I understan your problem.
> This is not an opinion. This is only a feedback that I have understood 
> Miguel's problem he was speaking of. But I don't means that I have the 
> same opinion.
>> 2)
>>> It may be improper to assume that there is an internal method called 
>>> InternalAllocateStr even more improper to assume that strings can be 
>>> modified but I don't think that using reflection to access non-public 
>>> members is improper.
> This is my opinion. And another important opinion is that if we assume 
> that our class library assemblies have permission to use unsafe code and 
> P/Invoke that are higher privileges we can assume that they have 
> reflection permissions as well. If they hasn't got these permissions 
> exceptions will be raised but this is true for unsafe code and P/Invoke 
> as well. So if our opinion is that we should not depend on permissions 
> we should not use either unsafe code or P/Invoke. And I think this is 
> somethig we don't want. But if our opinion is that it's OK to require 
> full trust or highly privileged permissions at least we can use 
> reflection as well.

Then it is very hard to understand why you posted a revised patch
that just removed reflection stuff. No one would think that you
disagree with Miguel when he or she read that reply.

Anyways it matches my understanding. Now we are ready to revert your
changes depending on the future direction without extra discussion
which might happen, as well as the possibility to add extra reflection
dependency. I don't like such extra dependency though, since it makes
code impossible to reuse or to try on other platforms than existing
mono itself.

Atsushi Eno

More information about the Mono-devel-list mailing list