[Mono-dev] Mono is VS II

[Zoltan Varga]

                                  Hi,

  The icall.c changes look ok to me. The Environment.cs change are mostly fine
too, but I think you should put back the NotImplementedExceptions () when
not running on windows instead of returning empty arrays and such.

                   Zoltan

On 6/9/06, Jonathan S. Chambers <Jonathan.Chambers at ansys.com> wrote:
> Here's a better patch, thanks to robertj. It opens the registry subkey
> in one call instead of 5 for machine level environment variables.
>
> Thanks,
> Jonathan
>
> > -----Original Message-----
> > From: mono-devel-list-bounces at lists.ximian.com
> [mailto:mono-devel-list-
> > bounces at lists.ximian.com] On Behalf Of Jonathan S. Chambers
> > Sent: Friday, June 09, 2006 1:54 PM
> > To: mono-devel-list at lists.ximian.com
> > Subject: [Mono-dev] Mono is VS II
> >
> > Here's another patch for building mono in VS. g_unsetenv and g_setenv
> > are not defined in the VS build. Let me know if the #ifdef's could be
> > made better/clearer. I think there was also a minor leak in the icall
> > method; if the user was unsetting an environment variable the method
> > returned without freeing the utf8_name variable.
> >
> > Note the whitespace change at the bottom of Environment.cs is removing
> > spaces from the end of the lines.
> >
> > I also implemented the User and Machine level options for
> > Set/GetEnvironmentVariable using the registry on Windows.
> >
> > Thanks,
> > Jonathan
> >
> >
>
>
>
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>
>
>