[Mono-dev] [PATCH] Speed up ByteEncoding.GetString()

Zac Bowling zac at zacbowling.com
Wed Jun 7 18:34:48 EDT 2006


opps... your other email didn't get threaded in my evolution. sorry bout
that...

On Wed, 2006-06-07 at 18:42 +0200, Kornél Pál wrote:
> Hi,
> 
> Right.:) But I posted a modified version in the response (the list is CC) to 
> Miguel's objections because I forgot to deal with the index parameter. And 
> this unnecessary unsafe marker is removed from that updated version. The 
> message also includes a performance comparsion.
> 
> Kornél
> 
> ----- Original Message ----- 
> From: "Zac Bowling" <zac at zacbowling.com>
> To: "Kornél Pál" <kornelpal at gmail.com>
> Cc: <mono-devel-list at lists.ximian.com>
> Sent: Wednesday, June 07, 2006 6:38 PM
> Subject: Re: [Mono-dev] [PATCH] Speed up ByteEncoding.GetString()
> 
> 
> > Cute. The second function doesn't look like it needs to be marked unsafe
> > though.
> >
> > On Tue, 2006-06-06 at 23:32 +0200, Kornél Pál wrote:
> >> Hi,
> >>
> >> ByteEncoding.GetString() currently uses StringBuilder that is very slow. 
> >> I
> >> modified it to use InternalAllocateStr and unsafe code that makes is much
> >> faster.
> >>
> >> Please review and approve the patch.
> >>
> >> Kornél
> >> _______________________________________________
> >> Mono-devel-list mailing list
> >> Mono-devel-list at lists.ximian.com
> >> http://lists.ximian.com/mailman/listinfo/mono-devel-list
> > -- 
> > Zac Bowling <zac at zacbowling.com>
> > 
> 
> 
-- 
Zac Bowling <zac at zacbowling.com>




More information about the Mono-devel-list mailing list