[Mono-dev] [PATCH] Use correct console code page on Windows (affects Linux as well)

[Kornél Pál]

Hi,

Now that module loading was patched is it OK to reapply the original patch 
or do you have any suggestions regarding the code?

Kornél

----- Original Message ----- 
From: "Zoltan Varga" <vargaz at gmail.com>
To: "Miguel de Icaza" <miguel at ximian.com>
Cc: "Kornél Pál" <kornelpal at gmail.com>; <mono-devel-list at lists.ximian.com>
Sent: Thursday, July 27, 2006 10:59 PM
Subject: Re: [Mono-dev] [PATCH] Use correct console code page on Windows 
(affects Linux as well)


> It looks ok to me.
>
>   Zoltan
>
> On 7/27/06, Miguel de Icaza <miguel at ximian.com> wrote:
>> Hello,
>>
>> > As for advapi32.dll and ole32.dll I don't think that these hints are 
>> > caused
>> > by my modifications.
>>
>> This was caused because the P/Invoke libraries are listed as external
>> modules.   The following patch fixes this, it avoids this by not loading
>> any external modules that are listed as P/Invokes, in that case we know
>> that the module is not a dll, but instead a native library.
>>
>> This was also biting us with Windows.Forms that tried to load Win32
>> libraries and Cocoa libraries, system tried to load fam and gamin and a
>> few more.
>>
>> Zoltan, any objections to this patch?
>>
>> Miguel.