[Mono-dev] System.IO.UnmanagedMemoryStream class implementation

[Sridhar Kulkarni]

Hi,

Thanks for your input and I have modified the UnmanagedMemoryStream class 
implementation as per your comments below. PLease consider this latest file 
and ignore the one which I have posted earlier. Also the Nunit test case for 
this class is attached.

Rgds,

-Sri


>From: Miguel de Icaza <miguel at ximian.com>
>To: Sridhar Kulkarni <sridharkulkarni at msn.com>
>CC: mono-devel-list at lists.ximian.com, mono-devel-list at ximian.com
>Subject: Re: System.IO.UnmanagedMemoryStream class implementation
>Date: Mon, 17 Jul 2006 11:16:40 -0400
>
>Hello Sridhar,
>
>      Thanks for your contribution to the UnmanagedMemoryStream.
>
>      Could you change your implementation to not use "canread" and
>"canwrite", but instead to use a field of type FileAccess and check
>against that value instead?
>
>      Also, identifiers should follow the conventions, so they should use
>underscores, like "current_pointer" instead of currentpointer.
>
>      The "Position" property should probably check against the boundary
>passed in "capacity" in the constructor (if this is not a MemoryStream
>buffer).   There is also a TODO item in the source code that must be
>reviewed.
>
>      Ideally, it would be great if you could write some NUnit tests
>cases as well to go along this implementation.
>
>Miguel.

_________________________________________________________________
Spice up your IM conversations. New, colorful and animated emoticons. Get 
chatting! http://server1.msn.co.in/SP05/emoticons/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: UnmanagedMemoryStramTest.cs
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20060725/41508270/attachment-0002.pl 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: UnmanagedMemoryStream.cs
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20060725/41508270/attachment-0003.pl