[Mono-dev] System.IO.UnmanagedMemoryStream class implementation

Miguel de Icaza miguel at ximian.com
Mon Jul 17 11:16:40 EDT 2006

Hello Sridhar,

     Thanks for your contribution to the UnmanagedMemoryStream.   

     Could you change your implementation to not use "canread" and
"canwrite", but instead to use a field of type FileAccess and check
against that value instead?    

     Also, identifiers should follow the conventions, so they should use
underscores, like "current_pointer" instead of currentpointer. 

     The "Position" property should probably check against the boundary
passed in "capacity" in the constructor (if this is not a MemoryStream
buffer).   There is also a TODO item in the source code that must be

     Ideally, it would be great if you could write some NUnit tests
cases as well to go along this implementation.


More information about the Mono-devel-list mailing list