[Mono-dev] [PATCH] Redirect certain string constructors to CreateString

[Kornél Pál]

Attached a modified version. Using a function instead of (-1) is a good idea 
not because g_assert_not_reached () can be used but because (-1) will not be 
monopolized to string constructors (altought it's very unlikely to need any 
other kind of redirection).

And I added two more g_asserts to ensure that CreateString methods are 
implemented using managed code.

If you have any other comments please let me know.

Kornél

----- Original Message ----- 
From: "Zoltan Varga" <vargaz at gmail.com>
To: "Kornél Pál" <kornelpal at gmail.com>
Sent: Wednesday, July 12, 2006 12:43 PM
Subject: Re: [Mono-dev] [PATCH] Redirect certain string constructors to 
CreateString


                                         Hi,

  This approach seems workable. It would be better to have a dummy string
ctor (eg ves_icall_System_String_ctor_CreateString with a body of
g_assert_not_reached ()) instead of the ICALL_... constant. Probably
only
mono_marshal_lock () is needed.

On 7/11/06, Kornél Pál <kornelpal at gmail.com> wrote:
> The previous one did not cache the results. Now this is fixed.
>
> BTW is mono_loader_lock () and mono_marshal_lock () necessary as well?
>
> Kornél
>
> ----- Original Message -----
> From: "Kornél Pál" <kornelpal at gmail.com>
> To: <mono-devel-list at lists.ximian.com>
> Sent: Tuesday, July 11, 2006 9:20 AM
> Subject: [PATCH] Redirect certain string constructors to CreateString
>
>
> > Hi,
> >
> > The attached patch implements what I was planning to do.
> >
> > Note that if the patch is approved I'm not going to commit is yet 
> > because
> > the encoding classes should be updated first.
> >
> > This patch contains String.cs modifications as well that should compile
> > with
> > the current encoding classes as well.
> >
> > I think this is a good solution and works for me but comments are 
> > welcome.
> >
> > Please review and approve the patch.
> >
> > Kornél
> >
>
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CreateString.diff
Type: application/octet-stream
Size: 5480 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20060712/a8ba9469/attachment.obj