[Mono-dev] Refactoring in System.Data.Common

Konstantin Triger kostat at mainsoft.com
Mon Jan 30 12:06:17 EST 2006


Hello,

I think that the most appropriate option (at least for GH) is to move
those classes into another namespace, say Mono.Data.Common, and make
them public.

If this is still unacceptable for mono, I will move either, but leave
the class declarations internal for mono and ifdef to public for GH.

Regards,
Konstantin Triger


-----Original Message-----
From: mono-devel-list-bounces at lists.ximian.com
[mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf Of Miguel de
Icaza
Sent: Monday, January 30, 2006 7:39 AM
To: Konstantin Triger
Cc: mono-devel-list at lists.ximian.com
Subject: Re: [Mono-dev] Refactoring in System.Data.Common

Hello,

> I made some methods/fields in System.Data.Common/ExceptionHelper.cs,
> DbTypes.cs to enable reuse in other assemblies like
> System.Data.OracleClient.

Like Ben pointed out this patch has the unintended side effect of
exposing types that are not part of the public API, so it can not be
applied.

What you could consider doing to share this information is to list the
necessary files that you need to share data with in the ".sources" file
for the other module.

If you need to re-namespace the constants, you could use an ifdef around
it.

Miguel.
_______________________________________________
Mono-devel-list mailing list
Mono-devel-list at lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list



More information about the Mono-devel-list mailing list