jonpryor at vt.edu
Mon Jan 23 05:29:34 EST 2006
On Sun, 2006-01-22 at 22:13 -0500, joel reed wrote:
> I'd like to implement System.Diagnostics.TraceSource if no one has already
> planned to do so. This is a 2.0 class.
> I've only submitted one bug fix previously to the mono project,
> so I thought I'd post the patch for TraceEventType, in the hopes
> that it would either be applied or else get needed feedback, and
> also let the list know I'd like to do TraceSource.
Feedback: don't use XML documentation comments. Documentation is kept
entirely separate, in the `monodoc' svn module. The documentation is
kept separate for translation reasons -- we can't have e.g. en and fr
documentation within the same source file.
You should also use tabs, not spaces, as is described here:
You also forgot a copyright statement in the file header, e.g.
// Joel Reed (joel.reed at ddiworld.com)
// Copyright (C) 2006 Joel Reed
// Permission is hereby granted, free of charge...
More information about the Mono-devel-list