[Mono-dev] System.Web.UI/HtmlTextWriter.cs issue

[Konstantin Triger]

Attached 2 patches, which, I believe, handle the issues better.

1. HtmlTextWriter.patch: addresses 1, 2 and 5.
2. button.patch:
	Point 3: My better understanding is that we must not delete user
data. Thus we may only append our logic.
	Point 4: not in this particular case.
	Point 5: Unfortunately I do not know how to create a unit test
for this scenario, as it depends on browser capabilities and some Page
properties. Is there a way to control this?

 
Regards,
Kosta


-----Original Message-----
From: Ben Maurer [mailto:bmaurer at ximian.com] 
Sent: Thursday, January 12, 2006 9:10 PM
To: Konstantin Triger
Cc: mono-devel-list at lists.ximian.com
Subject: Re: [Mono-dev] System.Web.UI/HtmlTextWriter.cs issue

> In this case the "return chk();" will be added to the onclick event in
> addition to the validation code there.

1) you should not use .ToLower to do case insensitive compares, but
String.Compare. Also, you must use the invariant culture.

2) Why would attrName (or the others) ever be null or empty

3) Is onclick the *only* attribute that this happens to?

4) Some of the microsoft code seems to add semicolons for you at the end
of js statements if you don't. Does this one do that too

5) No patch should ever be made without test cases.

-- Ben


-------------- next part --------------
A non-text attachment was scrubbed...
Name: HtmlTextWriter.patch
Type: application/octet-stream
Size: 2224 bytes
Desc: HtmlTextWriter.patch
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20060115/186b68d3/attachment.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: button.patch
Type: application/octet-stream
Size: 812 bytes
Desc: button.patch
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20060115/186b68d3/attachment-0001.obj