[Mono-dev] RE: Your recent commit.

[Miguel de Icaza]

Hey,

    Ignore my previous message;   They were only the pragmas that had
the problem, and they are not much of an issue.
> Hello Miguel,
> 
> Sorry, I missed several changes where I removed warning suppressions
> from the global scope. Those fail compilation on csc 1.1 even if inside
> the #ifdef NET_2_0 blocks.
> 
> Please let me know if this is not appropriate, so I'll put them back and
> think about an alternative solution.
> 
> Regards,
> Konstantin Triger
> 
> 
> -----Original Message-----
> From: Miguel de Icaza [mailto:miguel at novell.com] 
> Sent: Sunday, January 08, 2006 3:28 PM
> To: Konstantin Triger
> Subject: Your recent commit.
> 
> Hello Konstantin,
> 
>     Your recent commit said:
> 
> 	"TARGET_JVM changes to let the compilation pass with csc 1.1."
> 
>     Those were not TARGET_JVM changes, those were *global* changes;  As
> such, it should have been discussed with the maintainers before you made
> this change.
> 
> Miguel
> 
-- 
Miguel de Icaza <miguel at novell.com>
Novell, Inc.