[Mono-dev] RE: Com Interop Patch

[Miguel de Icaza]

Hello,

    My comments are as follows:

	* Please provide a ChangeLog for all the changes.

	* New fields in structures need to include documentation.
	  I know that we have not done this in the past, but we are
	  trying to rectify this, so for new patches, we should include
	  a description of the field, and any potential notes on its
	  use.

	* Any new public methods need to be documented using the 
	  format that can be seen in files like object.c:

		/**
		 * method: 
	 	 * arg1: bla bla
	  	 * arg2: bla bla
		 *
		 * Description
		 *
		 * Returns bla bla
		 */

Miguel
> The patch was too big. Attached is the patch to mono. The next email
> will have the patch to mcs.
> 
> -----Original Message-----
> From: Jonathan S. Chambers 
> Sent: Friday, January 06, 2006 11:33 AM
> To: mono-devel-list at lists.ximian.com
> Subject: Com Interop Patch
> 
> 	Here's a first attempt at a patch for COM Interop. This only
> provides support for RCWs (Runtime Callable Wrappers), i.e. using
> unmanaged COM components from managed code. This should support both
> classes used from Interop Assemblies (where metadata is known), as well
> as bare interface pointers (with no metadata) who are wrapped using
> __ComObject.
> 
> 	The patch doesn't seem to introduce any regression failures, and
> theoretically no code in this patch should even be hit unless you are
> using COM Interop functionality.
> 
> 	Just as a quick update, as much functionality as possible has
> been moved to managed code (either in the Marshal or COMInteropHelpers
> classes). This helps maintenance, doesn't bloat the runtime with
> component specific code, removes compile time dependencies, etc. I'm
> hoping for all code in the runtime to be generic component support code.
> All specific component code (COM, XPCOM, Mainwin COM) will be in
> managed. 
> 
> 	There's lots left to do, but this provides basic functionality.
> I'm sure the patch needs cleanup before commit, so please let me know
> what needs changed.
> 
> Thanks,
> Jonathan
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
-- 
Miguel de Icaza <miguel at ximian.com>