[Mono-dev] [PATCH] Minor fixes for XmlElement & XmlTextWriter

Atsushi Eno atsushi at ximian.com
Wed Jan 4 22:53:31 EST 2006

Hi Gert,

It would be nicer if you avoid application/octet-stream to post

In XmlElementTests.cs, I think those additional lines could be split
to another method and be shared (since null seems equivalent as
String.Empty in 2.0).

As for your code in general, please conform to coding guidelines
e.g. switch-case indentation and having extra brace for one liner
if-s (especially considering that you often do code reformatting;
doing it ignoring coding guidelines won't be welcomed).

If you agree with above please commit the patch after fixing them
(no need to excuse as long as changes are related only to above).

Atsushi Eno

Gert Driesen wrote:
> Hi,
> I've attached a patch that fixes the following minor issues in XmlElement
> and XmlTextWriter :
> - Setting XmlElement.Prefix to null should not result in
> ArgumentNullException on 2.0 profile
> - XmlTextWriter.WriteNmToken should throw ArgumentException if name is null
> or zero-length string
> - XmlTextWriter.WriteWhitespace should throw ArgumentException if name is
> null or zero-length string
> All changes are accompanied by unit tests and have been tested on Mono
> 1.0/2.0 profile, and MS.NET 1.1/2.0.
> Is it ok to commit these changes (as is) ?
> Gert
> ------------------------------------------------------------------------
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list

More information about the Mono-devel-list mailing list