[Mono-dev] [Patch] Constant changes in mono/support/serial.c

Paolo Molaro lupus at ximian.com
Wed Feb 22 09:50:30 EST 2006

On 02/22/06 Carlos Alberto Cortez wrote:
> The attached patch updates some comparisons in mono/support/serial.c
> (some values inside System.IO.Ports changed and need to be taken in
> count).
> May I proceed?

Please introduce an enum in the C code that mirrors the one in C# code
and use that instead of the magic numbers. Also, add a comment to the C#
code of the enum that warns that the two need to be kept in sync, so
the next time someone adds to them, they will hopefully also change the
C side.
After that you can commit.


lupus at debian.org                                     debian/rules
lupus at ximian.com                             Monkeys do it better

More information about the Mono-devel-list mailing list