[Mono-dev] Bug in System.Web.UI.WebControls.BoundColumn

[Chris Toshok]

yeah, I figured it was more efficient (for ms at least - do we inline
the getter?)..  my argument was more a consistency thing - there are
other != "" usages in that file.  Change them all or change none,
basically :)

actually running FxCop or something over the current System.Web might
not be a bad idea...

Chris

On Fri, 2006-02-17 at 06:38 -0500, Jonathan Pryor wrote:
> On Thu, 2006-02-16 at 20:51 -0500, Chris Toshok wrote:
> > This patch looks okay, except for the switch from 'df != ""' to
> > 'df.Length != 0'.  I'd prefer the former (and in general I'd rather
> > adapt whatever my thoughts are on the matter to what the original author
> > wrote.)
> 
> `df != ""' may make more sense than `df.Length != 0', but the latter is
> much faster than the former, and FxCop always suggests the latter over
> the former.
> 
> If you ever intend on using FxCop or similar tools regularly, you might
> consider following the guidelines to reduce the number of warnings
> generated. :-)
> 
>  - Jon
> 
>