[Mono-dev] [PATCH] MS/Mono incompatibility in System.Web.HttpRequest

[Edward C. Eisenbrey]

Attached is the patch including all the changes mentioned.


-----Original Message-----
From: Joshua Kugler [mailto:joshua.kugler at uaf.edu] 
Sent: Monday, February 13, 2006 5:12 PM
To: mono-devel-list at lists.ximian.com
Subject: Re: [Mono-dev] MS/Mono incompatibility in
System.Web.HttpRequest

On Monday 13 February 2006 12:49, Luca wrote:
> Il Mon, Feb 13, 2006 at 11:20:53AM -0900, Joshua Kugler ha scritto:
> > On Monday 13 February 2006 11:12, Alex Chudnovsky wrote:
> > > Edward C. Eisenbrey wrote:
> > > >using System.Text.RegularExpressions;
> > > >
> > > >static bool CheckString (string val)
> > > >{
> > > >	Regex regex = new Regex("<[a-zA-Z\\!]+");
> > > >	Match match = regex.Match(val);
> > > >	return match.Success;
> > > >}
> > >
> > > Pardon my instrusion, but would it not be better performance wise
to
> > > create static instance of the regexp to avoid doing it every time
> > > CheckString called? Ie:
> > >
> > > static Regex regex = new Regex("<[a-zA-Z\\!]+");
> > >
> > > static bool CheckString (string val)
> > > {
> > >
> > > 	Match match = regex.Match(val);
> > > 	return match.Success;
> > > }
> >
> > Or at least declare it static in the sub (I assume you can do that)?
>
> Well, no :) The "sub" is a method, so the regex object must be a
static
> member of the class. Back on the original topic, if that codepath is
realy
> performance critical you can even compile the Regex:

Ah! I missed the part about the method being part of a class.  Yes, a
static 
class member would probably be best.

j----- k-----

-- 
Joshua Kugler                 PGP Key: http://pgp.mit.edu/
CDE System Administrator             ID 0xDB26D7CE
http://distance.uaf.edu/
_______________________________________________
Mono-devel-list mailing list
Mono-devel-list at lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list



-------------- next part --------------
A non-text attachment was scrubbed...
Name: file2.diff
Type: application/octet-stream
Size: 921 bytes
Desc: file2.diff
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20060215/8e621c99/attachment.obj