[Mono-dev] DataTable bug in 1.1.13

[Konstantin Triger]

Hi Senga,

OK, agree with your correction. The patch I proposed is not complete.
Like you said, we probably should use also the CommandBehavior to get
the right MissingSchemaAction parameter while forwarding to the static
variant of the BuildSchema.

Regards,
Kosta


-----Original Message-----
From: T Senganal [mailto:tsenganal at novell.com] 
Sent: Sunday, February 05, 2006 5:17 PM
To: mono-devel-list at lists.ximian.com; Konstantin Triger
Subject: RE: [Mono-dev] DataTable bug in 1.1.13

Hi 

>The default for AllowDBNull is true, so only when MissingSchemaAction
is
>set to AddWithKey and when it's logically correct, the AllowDBNull
will
>be set to false - exactly what we need. Please verify this with the
>code.

Ignore my prev suggestion to set it if is MissingSchemaAction  set to
AddWithKey.. That was incorrect :-(

FillSchema needs to set the AllowDBNull value unless
MissingSchemaAction is Ignore or Error.

If we apply the patch, then AllowDBNull value wil lbe set only if
MissingSchemaAction is AddWithKey 'and'
other conditions like (isKey etc) are true and that is not correct..
Pls refer to bug #76433 ..

Will need to dig a lil bit more on this.. ms.net seems to depend on the
value of CommandBehavior (have to verify this).. 

Regards
senga