[Mono-dev] Ask for patch review

[Sebastien Pouliot]

On Wed, 2006-12-13 at 10:36 +0100, "Andrés G. Aragoneses [ knocte ]"
wrote:
> Sebastien Pouliot escribió:
> > The tests should include
> > - using an assembly name with a public key
> > - using an assembly name without a public key
> > - using an assembly name from a dynamic assembly (created using SRE)
> > - serialization/deserialization
> > and should be tested against both Fx 1.1 and 2.0.
> 
> Ok, I understand all the cases (and I have testcases for all now) except 
> the serialization/deserialization one. Do you mean to serialize an 
> assemblyName, and deserialize it, so as to see that the publicKey has 
> not changed?

Yes. This can be done with a few tests. One is a roundtrip, where the
runtime serialize to a byte array, then deserialize from it and compare
the values.

Another is keeping a copy from MS serialization (byte array),
deserialize it under the executing runtime and compare the values with
the expected ones. This case, when executed under Mono, also confirms
serialization compatibility. It is possible that you'll need a
serialized byte array from 1.1 class lib and another one for 2.0 (if the
format changed).

This pattern is used in a few places inside corlib unit tests.

Thanks,
-- 
Sebastien Pouliot  <sebastien at ximian.com>
Blog: http://pages.infinit.net/ctech/