[Mono-dev] [PATCH] Login control fixes

[Chris Toshok]

For bug fixes, please include along with the patch a test case
(standalone aspx/master files is file) that shows the bug in the current
code.

Chris

On Tue, 2006-04-25 at 22:03 +0200, Marek Habersack wrote:
> Hello everybody,
> 
>   The attached patch fixes two problems with the Login control in Mono:
> 
>  - As per http://msdn2.microsoft.com/en-us/library/system.web.ui.webcontrols.login.destinationpageurl.aspx
>    the patch makes Login redirect the user to destination page, in the
>    following precedence:
> 
>      - DestinationPageUrl property
>      - Referring page
>      - Forms authentication defaultUrl
>      - The login page itself
> 
>  - When the login control is used inside a content placeholder with a master
>    page (e.g. http://asp.net/QuickStart/util/srcview.aspx?path=~/aspnet/samples/ctrlref/login/Login.src)
>    Mono will throw an exception referring to line 1332 in Login.cs. The
>    patch fixes that by checking whether FormsAuthentication.LoginUrl is not
>    null. 
>    I'm not sure whether the fix is correct, though, since the bug might be
>    in FormsAuthentication code. The reason might be that the Initialize
>    method of the FormsAuthentication class is not called before
>    Login.IsDefaultLoginPage().
> 
> best regards,
> 
> marek
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list