[Mono-dev] LinkedStyleSheets in PageThemeCompiler

[Gonzalo Paniagua Javier]

On Sun, 2006-04-23 at 01:31 -0700, Andrew Skiba wrote:
> Hi Gonzalo,
> 
> First I forgot to use VirtualPathUtility.Combine and committed my patch
> with simple concatenation. Immediately after that, I noticed my mistake
> and tried to fix it.
> 
> But when I used VirtualPathUtility.Combine, I've got ArgumentException
> ("basePath is not an absolute path", "basePath"); 

Then use UrlUtils.Combine, which does not have that many restrictions.

> 
> The basePath comes from Page.InitializeStyleSheet, and it's hard coded
> to be relative path.
> 
> I see that many pathes are combined with simple concatenation. See 2
> lines later:
> 
> PageThemeFileParser ptfp = new PageThemeFileParser (virtualPath +
> Path.GetFileName (skin_files[i]),

That is wrong too.

-Gonzalo