[Mono-dev] PageThemeFileParser.AddDirective

Andrew Skiba andrews at mainsoft.com
Tue Apr 11 03:15:13 EDT 2006


Hi Chris,

Please review the new patch.

BTW, what do you think on refactoring ThrowParseException into throw
ParseException? I mean to create the exception in the helper function,
but to throw it explicitely?

Thank you,
Andrew.

Index: PageThemeFileParser.cs
===================================================================
--- PageThemeFileParser.cs	(revision 59261)
+++ PageThemeFileParser.cs	(working copy)
@@ -51,8 +51,11 @@
 		}
 
 		internal override void AddDirective (string directive,
Hashtable atts)
-		{
-			ThrowParseException ("Unknown directive: " +
directive);
+		{
+			if (string.CompareOrdinal (directive,
"Register") == 0)
+				base.AddDirective (directive, atts);
+			else
+				ThrowParseException ("Unknown directive:
" + directive);
 		}
 
 		internal override Type DefaultBaseType {



More information about the Mono-devel-list mailing list