[Mono-dev] patch for System.Web.UI.WebControls/Login control

Sebastien Pouliot sebastien.pouliot at gmail.com
Wed Apr 5 09:28:47 EDT 2006

Hello Konstantin,

On Wed, 2006-04-05 at 03:04 -0700, Konstantin Triger wrote:
> The attached patch enables LayoutTemplate property of login control.
> A relevant test is inside the patch.

Thanks for updating the test suite too :)

> If no one objects I’ll check in.

None about the code itself - and only a few about the style.

+               private void UserName_TextChanged(object sender, EventArgs e) {
+                       UserName = ((ITextControl)sender).Text;

a. There should be a space between the method name and the '(';
b. The '{' should be on it's own line (happens a few times).

Also be aware that the code was written (last summer) before Mono had
any working provider (so testing was limited to a very dumb provider).

Thanks for updating the code!
Sebastien Pouliot  <sebastien at ximian.com>
Blog: http://pages.infinit.net/ctech/

More information about the Mono-devel-list mailing list