[Mono-dev] [PATCH] Reworked ImageList (updated)

[Kornél Pál]

Hi,

> Hey Kornel, thanks very much for working on this. After applying this
> patch and updating and rebuilding my libgdiplus (saw you had a patch
> there) the winforms/treeview sample is crashing for me.

If you mean libgdiplus on "saw you had a patch there" you missed something
becasue I don't hack on libgdiplus.
I only tested the code on Windows, it works. I don't use graphical Linux so
I haven't got a test environment for libgdiplus. That's why I asked to do
some tests.:)

I did not try this sample previously but now I tried on Windows and works
for me without problems.

If there really is a problem with libgdiplus it may be a difference in
LockBits behaviour.

Please try the safe and the unsafe versions as well. I expect performance
loss when using GetPixel and SetPixel because it does a lot of unnecessary
things. If the safe version works there is something wrong with the unsafe
version. May be my code and may be libgdiplus.

Kornél

----- Original Message -----
From: "Jackson Harper" <jackson at ximian.com>
To: "Kornél Pál" <kornelpal at hotmail.com>
Cc: <mono-devel-list at lists.ximian.com>
Sent: Tuesday, September 27, 2005 9:10 AM
Subject: Re: [Mono-dev] [PATCH] Reworked ImageList (updated)


> On Mon, 2005-09-26 at 23:30 +0200, Kornél Pál wrote:
>> Hi,
>>
>> I updated the proposed path: Created an IndexedColorDepths nested class
>> that
>> delays palette initialization until it is needed and added an array that
>> contains sqare values for color distances. This should speed up
>> ReduceColorDepth.
>
> Hey Kornel, thanks very much for working on this. After applying this
> patch and updating and rebuilding my libgdiplus (saw you had a patch
> there) the winforms/treeview sample is crashing for me.
>
> Have you tried running this test?
>
> Thanks!
> Jackson
>
>
>> Kornél
>>
>> ----- Original Message -----
>> From: "Kornél Pál" <kornelpal at hotmail.com>
>> To: <mono-devel-list at lists.ximian.com>
>> Sent: Monday, September 26, 2005 2:14 PM
>> Subject: [Mono-dev] [PATCH] Reworked ImageList
>>
>>
>> > Hi,
>> >
>> > I modified nearly everything in ImageList implementation to make it
>> > compatible wint MS.NET.
>> >
>> > For more information look at the source code. The biggest change is
>> > that
>> > it
>> > uses 32-bit ARGB Images anyway to can provide transparency and can
>> > return
>> > the expected 32-bit Images. To provide compatibility with MS.NET it
>> > reduces
>> > colors and ignores non-zero alpha levels according to the ColorDepth
>> > property.
>> >
>> > Please do some tests with the new implementation with MS GDI+ as well
>> > as
>> > Mono libgdiplus.
>> >
>> > Please review and approve the patch.
>> >
>> > Kornél
>> >
>>
>>
>> --------------------------------------------------------------------------------
>>
>>
>> > _______________________________________________
>> > Mono-devel-list mailing list
>> > Mono-devel-list at lists.ximian.com
>> > http://lists.ximian.com/mailman/listinfo/mono-devel-list
>> >
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at lists.ximian.com
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ImageListSafeUnsafe.tar.gz
Type: application/x-gzip
Size: 5269 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20050927/a759bba2/attachment.gz