[Mono-dev] questions regarding contributing

[Rafael Teixeira]

We are trying to follow .NET 2.0 API changes as needed (they are
nearly frozen now as the launch date for it is around November).

Just that 2.0 specifics need to be conditionally compiled only for the
2_0 profile.

So just be sure to have such code surrounded by

#if NET_2_0

#endif // NET_2_0

or added to an existing block delimited as such.

Diffs for such patches may be submitted here or better yet attached to
a corresponding bugzilla case, and should contain a changelog entry,
and ideally unit tests to exercise the added/modified code .

Thanks,

On 9/14/05, Andy Waddell <awaddell at fnfr.com> wrote:
>  
>  
> 
> Sorry if this message get duplicated, but I'm having some trouble posting
> it. 
> 
>   
> 
> Hi all.  
> 
>   
> 
> I work at a start up here in Silicon Valley (http://www.fnfr.com) and I'm
> tasked with getting a subset of our application to run on Mono.  It's all
> being coded in C# using MS Visual Studio 2005 Beta 2 and the development
> team is coding to the 2.0 .NET and making full use of generics, etc.  I have
> an environment set up on Linux with anonymous SVN access so that I can stay
> current.  So far, I've managed to get most of the code I need to compile
> (using gmcs) and my next task will be to get the unit tests up and running
> in some form so that I can verify the runtime behavior.  
> 
>   
> 
> The first set of issues I ran into were pieces of the class library not yet
> in the Mono base, but in the Beta 2 version of .NET 2.0.  In each case I've
> either worked around it in our code by substituting from the 1.0 Framework
> or gone into my local copy of the Mono code and added what we needed.  I
> don't have write access to SVN, so my changes are local for now, but I'd be
> more that happy to contribute them (and our management is supportive of
> this).  So far my additions have been limited to a few trivial items.  For
> example,
> System.Data.SqlTypes.SqlParameterCollection.AddWithValue is
> a new method in 2.0 that was being used in several places in our code base. 
> I got past this by adding: 
> 
>   
> 
> [awaddell at AWLNX awaddell]$ cd
> src/mcs/class/System.Data/System.Data.SqlClient 
> 
> [awaddell at AWLNX System.Data.SqlClient]$ svn diff SqlParameterCollection.cs 
> 
> Index: SqlParameterCollection.cs 
> 
> ===================================================================
> 
> --- SqlParameterCollection.cs   (revision 49758) 
> 
> +++ SqlParameterCollection.cs   (working copy) 
> 
> @@ -258,6 +258,11 @@ 
> 
>                         return Add (new SqlParameter (parameterName,
> sqlDbType, size, sourceColumn)); 
> 
>                 } 
> 
>   
> 
> +               public SqlParameter AddWithValue(string parameterName,
> object value) 
> 
> +               { 
> 
> +                        return Add(new SqlParameter(parameterName, value));
> 
> +               } 
> 
> + 
> 
>                 public 
> 
>  #if NET_2_0 
> 
>                 override 
> 
> [awaddell at AWLNX System.Data.SqlClient]$ 
> 
>   
> 
> I've done 4 or 5 other little ones like this, but I'm not sure what the
> policy is regarding the .NET Framework version 2.0 stuff.  Given that the
> code in Beta 2 is subject to change, is there a hesitancy to apply all the
> stuff in Beta 2 to the Mono code base or is it just the case that nobody has
> gotten around to it?  If it's the latter, maybe we can help.  Should I
> request write access to SVN or since my changes are so small, just post them
> to this (or some other) list?  Is there a definitive place to check the
> status of what's done and what's not (other than the source code)?  
> 
>   
> 
> I have some other questions, but this is getting to be a long post already. 
> Any guidance would be greatly appreciated. 
> 
>   
> 
> --andy 
> 
>   
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
> 
> 
> 


-- 
Rafael "Monoman" Teixeira
---------------------------------------
I'm trying to become a "Rosh Gadol" before my own eyes. 
See http://www.joelonsoftware.com/items/2004/12/06.html for enlightment.
It hurts!