[Mono-dev] Re: Patch with TARGET_JVM changes for some classes from System.Runtime.Remoting

Lluis Sanchez lluis at ximian.com
Mon Oct 31 05:03:14 EST 2005


> Hi all,
> I changed some code under TARGET_JVM condition.
> 
> Can I commit this changes?
> 

The patches look fine. The only change I don't understand is this:
> 
> Index: SdlChannelSink.cs
> ===================================================================
> --- SdlChannelSink.cs   (revision 52268)
> +++ SdlChannelSink.cs   (working copy)
> @@ -108,7 +108,11 @@
>                                 catch (Exception ex)
>                                 {
>                                         responseHeaders = new
> TransportHeaders ();
> +#if !TARGET_JVM
>                                         responseHeaders
> [CommonTransportKeys.HttpStatusCode] = "500";
> +#else
> +                                       responseHeaders
> [CommonTransportKeys.HttpStatusCode] = "400";
> +#endif
>                                         responseStream = new
> MemoryStream (Encoding.UTF8.GetBytes (ex.ToString ()));
>                                 }
>                                 return ServerProcessing.Complete; 

What's wrong with the 500 error code?

Lluis.





More information about the Mono-devel-list mailing list