[Mono-dev] [Fwd: [Mono-patches] r51466 - trunk/mcs/class/System.XML/System.Xml.XPath]

Atsushi Eno atsushi at ximian.com
Sat Oct 8 12:19:23 EDT 2005


Hi Gert,

Please note that adding ReplaceRange() and DeleteRange() without
MonoTODO could bring confusion, though the abstract XPathNavigator
raises an exception as you coded.

Or please just implement those members as well ;-)

Thanks for the API fixes btw.

Atsushi Eno


-------- Original Message --------
Subject: [Mono-patches] r51466 - trunk/mcs/class/System.XML/System.Xml.XPath
Date: Sat,  8 Oct 2005 07:44:26 -0400 (EDT)
From: Gert Driesen (gert.driesen at pandora.be) 
<mono-patches-list at lists.ximian.com>
To: mono-patches at lists.ximian.com, ximian.monolist at gmail.com, 
mono-patches-list at googlegroups.com

Author: gert
Date: 2005-10-08 07:44:25 -0400 (Sat, 08 Oct 2005)
New Revision: 51466

Modified:
    trunk/mcs/class/System.XML/System.Xml.XPath/ChangeLog
    trunk/mcs/class/System.XML/System.Xml.XPath/XPathNavigator.cs
    trunk/mcs/class/System.XML/System.Xml.XPath/XPathNodeIterator.cs
Log:
* XPathNavigator.cs: [NET_2_0] Added DebuggerDisplay attribute,
added ReplaceRange and DeleteRange methods.
* XPathNodeIterator.cs: [NET_2_0] Added DebuggerDisplay attribute.


Modified: trunk/mcs/class/System.XML/System.Xml.XPath/ChangeLog
===================================================================
--- trunk/mcs/class/System.XML/System.Xml.XPath/ChangeLog	2005-10-08 
11:26:54 UTC (rev 51465)
+++ trunk/mcs/class/System.XML/System.Xml.XPath/ChangeLog	2005-10-08 
11:44:25 UTC (rev 51466)
@@ -1,3 +1,9 @@
+2005-10-08  Gert Driesen  <drieseng at users.sourceforge.net>
+
+	* XPathNavigator.cs: [NET_2_0] Added DebuggerDisplay attribute,
+	added ReplaceRange and DeleteRange methods.
+	* XPathNodeIterator.cs: [NET_2_0] Added DebuggerDisplay attribute.
+
  2004-09-22  Atsushi Enomoto  <atsushi at ximian.com>

  	* Expression.cs : Now that managed collation is default, we don't need

Modified: trunk/mcs/class/System.XML/System.Xml.XPath/XPathNavigator.cs
===================================================================
--- trunk/mcs/class/System.XML/System.Xml.XPath/XPathNavigator.cs 
2005-10-08 11:26:54 UTC (rev 51465)
+++ trunk/mcs/class/System.XML/System.Xml.XPath/XPathNavigator.cs 
2005-10-08 11:44:25 UTC (rev 51466)
@@ -34,6 +34,7 @@
  #if NET_2_0
  using System.Collections;
  using System.Collections.Generic;
+using System.Diagnostics;
  #endif
  using System.IO;
  using System.Xml;
@@ -49,6 +50,7 @@
  namespace System.Xml.XPath
  {
  #if NET_2_0
+	[DebuggerDisplay ("{new DebuggerDisplayProxy(this)}")]
  	public abstract class XPathNavigator : XPathItem,
  		ICloneable, IXPathNavigable, IXmlNamespaceResolver
  #else
@@ -1045,6 +1047,16 @@
  			throw new NotSupportedException ();
  		}

+		public virtual void DeleteRange (XPathNavigator nav)
+		{
+			throw new NotSupportedException ();
+		}
+
+		public virtual XmlWriter ReplaceRange (XPathNavigator nav)
+		{
+			throw new NotSupportedException ();
+		}
+	
  		public virtual XmlWriter InsertAfter ()
  		{
  			XPathNavigator nav = Clone ();

Modified: trunk/mcs/class/System.XML/System.Xml.XPath/XPathNodeIterator.cs
===================================================================
--- trunk/mcs/class/System.XML/System.Xml.XPath/XPathNodeIterator.cs 
2005-10-08 11:26:54 UTC (rev 51465)
+++ trunk/mcs/class/System.XML/System.Xml.XPath/XPathNodeIterator.cs 
2005-10-08 11:44:25 UTC (rev 51466)
@@ -30,10 +30,14 @@

  using System;
  using System.Collections;
+#if NET_2_0
+using System.Diagnostics;
+#endif

  namespace System.Xml.XPath
  {
  #if NET_2_0
+	[DebuggerDisplay("Position={CurrentPosition}, Current={Current == null 
? null : (object) new XPathNavigator.DebuggerDisplayProxy(Current)}")]
  	public abstract class XPathNodeIterator : ICloneable, IEnumerable
  #else
  	public abstract class XPathNodeIterator : ICloneable

_______________________________________________
Mono-patches maillist  -  Mono-patches at lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-patches




More information about the Mono-devel-list mailing list